From 2a18d27530ca150bfb7569966406d5fc3e5d3098 Mon Sep 17 00:00:00 2001 From: kiu Date: Wed, 3 Aug 2011 22:54:42 +0200 Subject: [PATCH] fixed stupid casting issues for overfloew detection --- firmware/applications/final/flame.c | 4 ++-- firmware/applications/flame.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/firmware/applications/final/flame.c b/firmware/applications/final/flame.c index 3943458..a9ce06a 100644 --- a/firmware/applications/final/flame.c +++ b/firmware/applications/final/flame.c @@ -94,7 +94,7 @@ void tick_flame(void) { // every 10ms } if (flameMode == FLAME_UP) { - if (flameI2Cpwm + flameSpeedUp > flameI2Cpwm ) { + if (0xFF - flameI2Cpwm >= flameSpeedUp ) { flameI2Cpwm += flameSpeedUp; } else { flameI2Cpwm = 0xFF; @@ -113,7 +113,7 @@ void tick_flame(void) { // every 10ms } if (flameMode == FLAME_DOWN) { - if (flameI2Cpwm - flameSpeedDown < flameI2Cpwm ) { + if (flameSpeedDown <= flameI2Cpwm) { flameI2Cpwm -= flameSpeedDown; } else { flameI2Cpwm = 0x00; diff --git a/firmware/applications/flame.c b/firmware/applications/flame.c index 2831505..80bd060 100644 --- a/firmware/applications/flame.c +++ b/firmware/applications/flame.c @@ -84,7 +84,7 @@ void tick_flame(void) { // every 10ms } if (flameMode == FLAME_UP) { - if (flameI2Cpwm + flameSpeedUp > flameI2Cpwm ) { + if (0xFF - flameI2Cpwm >= flameSpeedUp) { flameI2Cpwm += flameSpeedUp; } else { flameI2Cpwm = 0xFF; @@ -103,7 +103,7 @@ void tick_flame(void) { // every 10ms } if (flameMode == FLAME_DOWN) { - if (flameI2Cpwm - flameSpeedDown < flameI2Cpwm ) { + if (flameSpeedDown <= flameI2Cpwm) { flameI2Cpwm -= flameSpeedDown; } else { flameI2Cpwm = 0x00;